mirror of
https://github.com/project-zot/zot.git
synced 2026-06-17 12:58:02 +08:00
Janko Thyson
a675ac96b9
GetAllDedupeReposCandidates propagated zerr.ErrCacheMiss from the cache's GetAllBlobs verbatim. But a cache miss is the normal case for a not-yet-cached blob — the first push of a new blob, or a cross-repo mount check during a push — and semantically means "no dedupe/mount candidates", not a failure. Propagating it caused canMount (used by the CheckBlob and CreateBlobUpload handlers) to surface the error, which the route handlers log as an "unexpected error". With remote (e.g. S3) storage a cache is always present (dedupe:false does not disable it), so this logs an error-level line for every fresh blob digest on every push — significant log spam during bulk pushes and cross-repo mounts, with no functional impact (the push still succeeds via a normal upload). Handle ErrCacheMiss the same way as the existing nil-cache branch above: return no candidates and no error. Signed-off-by: Janko Thyson <janko@kaosmaps.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
zot
zot: a production-ready vendor-neutral OCI image registry - images stored in OCI image format, distribution specification on-the-wire, that's it!
Documentation for zot is located at: https://zotregistry.dev
Code of conduct details are here.
License
