mirror of
https://github.com/project-zot/zot.git
synced 2026-06-17 21:17:58 +08:00
95ce68ccb0
* refactor(test/blackbox): extract shared push/pull helpers Move duplicated push/pull/regclient/oras/helm helper functions out of fips140.bats, pushpull.bats and helpers_upgrade.bash into a single helpers_pushpull.bash, then have all three suites load from there. The helpers now share verify_prerequisites, get_zot_port, common assertion helpers (catalog/tag presence, OCI index ref name) and the regclient pagination listing. helpers_upgrade.bash keeps only the test_release_* and test_new_* wrappers that compose those helpers. Net effect: ~1000 lines of duplicated test scaffolding removed across the four files; behavior of the existing test cases is preserved. Refs: #3727 Signed-off-by: Akash Kumar <meakash7902@gmail.com> * refactor(test/blackbox): share pushpull lifecycle and dedupe authn helpers Build on the shared helpers_pushpull.bash to remove more duplicated blackbox scaffolding: - Add pushpull_setup_file/pushpull_teardown/pushpull_teardown_file keyed on PUSHPULL_FIPS_MODE so pushpull.bats and fips140.bats only set the flag and delegate lifecycle, instead of each carrying a near-identical setup_file/teardown. - Add helpers_pushpull_authn.bash (loaded by pushpull_authn.bats and fips140_authn.bats) for shared htpasswd setup, FIPS vs non-FIPS config and teardown, and the regclient/OCI/ML test helpers; both authn suites collapse to one-line @test bodies keyed on PUSHPULL_AUTHN_FIPS_MODE. - Make each authn helper self-sufficient by performing its own regctl login, removing the hidden dependency on the first test having logged in. - Split the implicit manifest delete out of helper_pull_image_index_and_delete into a standalone helper_delete_manifest, surfaced as its own "delete image index" @test in the pushpull, fips140 and upgrade suites, so the delete is explicit and no longer an order-fragile side effect of a pull. Refs: #3727 Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> * fix(test/blackbox): harden flaky oras pull and sync signature tests Set org.opencontainers.image.title on oras artifact push and verify pull both via oras pull and manifest/blob fetch. Add retry_until_success and use it for periodic notation/cosign signature sync checks on slow CI. Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> * fix(test/blackbox): address Copilot review feedback in push/pull helpers Use curl --fail for manifest deletes so HTTP errors fail the test. Remove the duplicate regctl --format flag in helper_push_manifest_with_regclient. Harden helper_authn_ml_artifacts with run and status checks, using a binary-safe shell redirect for the ONNX artifact round-trip. Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> * fix(test/blackbox): isolate pushpull helper temp files and prerequisites Write oras artifact and docker build files under BATS_TEST_TMPDIR instead of the test working directory, and check git/docker in verify_prerequisites for clearer failures when running bats directly. Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> * fix(test): use verify_prerequisites exit status in bats setup Replace `$(verify_prerequisites)` with a direct call across blackbox and scale-out suites. Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> * fix(test/blackbox): unify blackbox log path to zot/zot-log.json Drop the FIPS vs non-FIPS split between zot-log.json and zot.log in pushpull, authn, and upgrade helpers. Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> * refactor(test/blackbox): loop over tools in verify_prerequisites Replace repeated command -v checks with a single loop over curl, jq, git, and docker. Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> * refactor(test/blackbox): fix exit code for retry_until_success Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> * refactor(test/blackbox): inline upgrade tests and drop helpers_upgrade Call helper_* directly from upgrade.bats and upgrade_minimal.bats, load helpers_pushpull in those suites, and move teardown there. Remove helpers_upgrade.bash now that the release/new wrappers are gone. Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> * refactor(test/blackbox): require explicit args on pushpull helpers Drop parameter defaults from shared push/pull helpers and pass image, repository, and pagination values explicitly at each call site. Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> * fix(test/blackbox): clarify docker push/pull negative test naming Rename helper_push_docker_image to helper_build_docker_image_push_and_pull and update test titles to reflect build plus expected push/pull failures without the docker compatibility extension. Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> * fix(test/blackbox): isolate regctl config per BATS suite regctl persists login and TLS settings on disk, so push/pull blackbox tests could leak state into ~/.regctl/config.json across suites. Point REGCTL_CONFIG at BATS_FILE_TMPDIR for pushpull, authn, and upgrade suites, configure TLS once in authn setup, and drop redundant logout and per-login TLS setup. Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> * fix(test/blackbox): harden upgrade suite log dump on failure Touch zot-log.json during upgrade setup and only cat it in teardown when the file exists, so a missing log cannot mask the underlying test failure. Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> --------- Signed-off-by: Akash Kumar <meakash7902@gmail.com> Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com> Co-authored-by: Akash Kumar <meakash7902@gmail.com>
122 lines
2.8 KiB
Bash
122 lines
2.8 KiB
Bash
# Note: Intended to be run as "make run-blackbox-tests" or "make run-blackbox-ci"
|
|
# Makefile target installs & checks all necessary tooling
|
|
# Extra tools that are not covered in Makefile target needs to be added in verify_prerequisites()
|
|
|
|
load helpers_zot
|
|
load helpers_pushpull
|
|
load ../port_helper
|
|
|
|
PUSHPULL_FIPS_MODE=0
|
|
|
|
function setup_file() {
|
|
pushpull_setup_file
|
|
}
|
|
|
|
function teardown() {
|
|
pushpull_teardown
|
|
}
|
|
|
|
function teardown_file() {
|
|
pushpull_teardown_file
|
|
}
|
|
|
|
@test "push image" {
|
|
helper_push_image golang 1.20 oci:${TEST_DATA_DIR}/golang:1.20
|
|
}
|
|
|
|
@test "pull image" {
|
|
helper_pull_image golang 1.20
|
|
}
|
|
|
|
@test "push image index" {
|
|
helper_push_image_index docker://public.ecr.aws/docker/library/busybox:latest busybox latest
|
|
}
|
|
|
|
@test "pull image index" {
|
|
helper_pull_image_index busybox latest
|
|
}
|
|
|
|
@test "delete image index" {
|
|
helper_delete_manifest busybox latest
|
|
}
|
|
|
|
@test "push oras artifact" {
|
|
helper_push_oras_artifact hello-artifact v2
|
|
}
|
|
|
|
@test "pull oras artifact" {
|
|
helper_pull_oras_artifact hello-artifact v2
|
|
}
|
|
|
|
@test "attach oras artifacts" {
|
|
helper_attach_oras_artifacts golang 1.20
|
|
}
|
|
|
|
@test "discover oras artifacts" {
|
|
helper_discover_oras_artifacts golang 1.20 2
|
|
}
|
|
|
|
@test "add and list tags using oras" {
|
|
helper_add_and_list_tags_using_oras
|
|
}
|
|
|
|
@test "push helm chart" {
|
|
helper_push_helm_chart
|
|
}
|
|
|
|
@test "pull helm chart" {
|
|
helper_pull_helm_chart
|
|
}
|
|
|
|
@test "push image with regclient" {
|
|
helper_push_image_with_regclient "ocidir://${TEST_DATA_DIR}/golang:1.20" test-regclient
|
|
}
|
|
|
|
@test "pull image with regclient" {
|
|
helper_pull_image_with_regclient test-regclient "ocidir://${TEST_DATA_DIR}/golang:1.20"
|
|
}
|
|
|
|
@test "list repositories with regclient" {
|
|
helper_list_repositories_with_regclient_pagination 2 busybox golang test-regclient "-2:busybox" "-1:golang"
|
|
}
|
|
|
|
@test "list image tags with regclient" {
|
|
helper_list_image_tags_with_regclient test-regclient
|
|
}
|
|
|
|
@test "push manifest with regclient" {
|
|
helper_push_manifest_with_regclient test-regclient 1.0.0
|
|
}
|
|
|
|
@test "pull manifest with regclient" {
|
|
helper_pull_manifest_with_regclient test-regclient
|
|
}
|
|
|
|
@test "pull manifest with docker client" {
|
|
helper_pull_manifest_with_docker_client test-regclient
|
|
}
|
|
|
|
@test "pull manifest with crictl" {
|
|
helper_pull_manifest_with_crictl test-regclient
|
|
}
|
|
|
|
@test "push OCI artifact with regclient" {
|
|
helper_push_oci_artifact_with_regclient artifact:demo
|
|
}
|
|
|
|
@test "pull OCI artifact with regclient" {
|
|
helper_pull_oci_artifact_with_regclient artifact:demo "this is an artifact"
|
|
}
|
|
|
|
@test "push OCI artifact references with regclient" {
|
|
helper_push_oci_artifact_references_with_regclient 0
|
|
}
|
|
|
|
@test "pull OCI artifact references with regclient" {
|
|
helper_pull_oci_artifact_references_with_regclient 1
|
|
}
|
|
|
|
@test "build docker image and verify docker push and pull fail" {
|
|
helper_build_docker_image_push_and_pull
|
|
}
|