sync: cleanup the orphaned private download dir on failure, closes 282

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>

pkg/extensions/sync/on_demand.go

@@ -87,6 +87,8 @@ func OneImage(cfg Config, log log.Logger,
 			return err
 		}
 
+		defer os.RemoveAll(path.Join(imageStore.RootDir(), imageName, SyncBlobUploadDir, uuid.String()))
+
 		localTaggedRepo := fmt.Sprintf("%s:%s", localRepo, tag)
 
 		localRef, err := layout.ParseReference(localTaggedRepo)

pkg/extensions/sync/sync.go

@@ -382,6 +382,8 @@ func syncRegistry(regCfg RegistryConfig, storeController storage.StoreController
 			return err
 		}
 
+		defer os.RemoveAll(path.Join(imageStore.RootDir(), imageName, SyncBlobUploadDir, uuid))
+
 		upstreamTaggedRef := getTagFromRef(upstreamRef, log)
 
 		localTaggedRepo := fmt.Sprintf("%s:%s", localRepo, upstreamTaggedRef.Tag())