github/zot
1
0
Fork 0
mirror of https://github.com/project-zot/zot.git synced 2026-06-17 21:17:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improve test and comment clarity based on code review feedback

Browse Source 
Co-authored-by: rchincha <45800463+rchincha@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-01 23:02:58 +00:00
parent c84d8a6d88
commit a484b61a0f
2 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/api/tlscert_test.go
+1 -1
View File
@@ -198,7 +198,7 @@ func TestCertReloaderDirectly(t *testing.T) {
So(cert, ShouldNotBeNil)
})
Convey("GetCertificateFunc should handle cert file modification", func() {
Convey("GetCertificateFunc should handle certificate and key file modification", func() {
reloader, err := api.NewCertReloader(certPath, keyPath, log.NewTestLogger())
So(err, ShouldBeNil)
defer reloader.Close()
test/blackbox/tls_cert_reload.bats
+7 -6
View File
@@ -193,14 +193,15 @@ function teardown_file() {
cert_subject_before=$(echo | openssl s_client -connect 127.0.0.1:${zot_port} -showcerts 2>/dev/null | \
openssl x509 -noout -subject 2>/dev/null)
# Temporarily remove certificate files (will cause reload to fail)
# Note: Moving the file won't trigger fsnotify (only Write/Create events are monitored),
# so this test relies on the maybeReload() fallback mechanism being triggered during
# the TLS handshake when curl connects below. This verifies the server continues
# serving with the old certificate when reload fails.
# Temporarily remove certificate files to test reload failure handling
# Note: Moving the file won't trigger fsnotify (only Write/Create events are monitored).
# This test relies on the maybeReload() fallback mechanism being triggered during
# the TLS handshake when curl connects below. The maybeReload() will attempt to
# reload and detect the missing file, but will fail gracefully. This verifies the
# server continues serving with the cached certificate when reload fails.
mv ${cert_dir}/server.cert ${cert_dir}/server.cert.backup
# Wait and try to connect - should still work with old certificate
# Wait and try to connect - should still work with cached certificate
# The maybeReload() mechanism will detect the missing file but won't fail the handshake
sleep 2
run curl --cacert ${cert_dir}/ca.crt https://127.0.0.1:${zot_port}/v2/