Fix Dockerfiles by moving the BASE_IMAGE arg into the global scope (#3536)

fix: Fix Dockerfiles by moving the BASE_IMAGE arg  into the global scope

Signed-off-by: Lars Francke <git@lars-francke.de>

build/Dockerfile

@@ -1,3 +1,13 @@
+# ---
+# Global ARGs for FROM statements
+# This needs to be declared in the global scope otherwise the build will fail in Docker & Podman.
+# Docker:
+#   WARNING: UndefinedArgInFrom - https://docs.docker.com/go/dockerfile/rule/undefined-arg-in-from/
+#   FROM argument 'BASE_IMAGE' is not declared
+# Podman: Error: determining starting point for build: no FROM statement found
+# ---
+ARG BASE_IMAGE
+
 # ---
 # Stage 1: Install certs, build binary, create default config file
 # ---
@@ -28,7 +38,6 @@ RUN echo '{\n\
 # ---
 # Stage 2: Final image with nothing but certs, binary, and default config file
 # ---
-ARG BASE_IMAGE
 FROM $BASE_IMAGE AS final
 ARG TARGETOS
 ARG TARGETARCH

build/Dockerfile-conformance

@@ -1,3 +1,13 @@
+# ---
+# Global ARGs for FROM statements
+# This needs to be declared in the global scope otherwise the build will fail in Docker & Podman.
+# Docker:
+#   WARNING: UndefinedArgInFrom - https://docs.docker.com/go/dockerfile/rule/undefined-arg-in-from/
+#   FROM argument 'BASE_IMAGE' is not declared
+# Podman: Error: determining starting point for build: no FROM statement found
+# ---
+ARG BASE_IMAGE
+
 # ---
 # Stage 1: Install certs, build binary, create default config file
 # ---
@@ -24,7 +34,6 @@ storage:\n\
 # ---
 # Stage 2: Final image with nothing but certs, binary, and default config file
 # ---
-ARG BASE_IMAGE
 FROM $BASE_IMAGE AS final
 ARG TARGETOS
 ARG TARGETARCH

build/Dockerfile-minimal

@@ -1,3 +1,13 @@
+# ---
+# Global ARGs for FROM statements
+# This needs to be declared in the global scope otherwise the build will fail in Docker & Podman.
+# Docker:
+#   WARNING: UndefinedArgInFrom - https://docs.docker.com/go/dockerfile/rule/undefined-arg-in-from/
+#   FROM argument 'BASE_IMAGE' is not declared
+# Podman: Error: determining starting point for build: no FROM statement found
+# ---
+ARG BASE_IMAGE
+
 # ---
 # Stage 1: Install certs, build binary, create default config file
 # ---
@@ -27,7 +37,6 @@ RUN echo '{\n\
 # ---
 # Stage 2: Final image with nothing but certs, binary, and default config file
 # ---
-ARG BASE_IMAGE
 FROM $BASE_IMAGE AS final
 ARG TARGETOS
 ARG TARGETARCH

build/Dockerfile-zb

@@ -1,3 +1,13 @@
+# ---
+# Global ARGs for FROM statements
+# This needs to be declared in the global scope otherwise the build will fail in Docker & Podman.
+# Docker:
+#   WARNING: UndefinedArgInFrom - https://docs.docker.com/go/dockerfile/rule/undefined-arg-in-from/
+#   FROM argument 'BASE_IMAGE' is not declared
+# Podman: Error: determining starting point for build: no FROM statement found
+# ---
+ARG BASE_IMAGE
+
 # ---
 # Stage 1: Install certs, build binary, create default config file
 # ---
@@ -15,7 +25,6 @@ RUN make COMMIT=$COMMIT OS=$TARGETOS ARCH=$TARGETARCH clean bench
 # ---
 # Stage 2: Final image with nothing but certs, binary, and default config file
 # ---
-ARG BASE_IMAGE
 FROM BASE_IMAGE AS final
 ARG TARGETOS
 ARG TARGETARCH

build/Dockerfile-zxp

@@ -1,3 +1,13 @@
+# ---
+# Global ARGs for FROM statements
+# This needs to be declared in the global scope otherwise the build will fail in Docker & Podman.
+# Docker:
+#   WARNING: UndefinedArgInFrom - https://docs.docker.com/go/dockerfile/rule/undefined-arg-in-from/
+#   FROM argument 'BASE_IMAGE' is not declared
+# Podman: Error: determining starting point for build: no FROM statement found
+# ---
+ARG BASE_IMAGE
+
 # ---
 # Stage 1: Build binary, create default config file
 # ---
@@ -28,7 +38,6 @@ RUN echo '{\n\
 # ---
 # Stage 2: Final image with nothing but binary and default config file
 # ---
-ARG BASE_IMAGE
 FROM $BASE_IMAGE AS final
 ARG TARGETOS
 ARG TARGETARCH