mirror of
https://github.com/project-zot/zot.git
synced 2026-06-15 11:37:56 +08:00
ci: fix golangci-lint install URL (#4052)
1. Cause
SBOM assets were added to the release checksum file, so you get two lines that contain the same substring, e.g. …linux-amd64.tar.gz and …linux-amd64.tar.gz.sbom.json.
The old install.sh logic used something like grep "${BASENAME}", so both lines matched. That breaks want (wrong or ambiguous hash) and shows up as checksum verification errors (including the 8df… vs fd3… style mismatch you debugged).
2. The upstream fix is in https://github.com/golangci/golangci-lint/pull/6539
The matcher was changed so the checksum line must end with the archive name — i.e. grep "${BASENAME}$" — so the .sbom.json line no longer matches.
3. In the same thread they say master on raw.githubusercontent.com is not the right branch anymore and recommend the canonical installer URL:
https://golangci-lint.run/install.sh
(see the PR description and local install / binaries.)
Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
This commit is contained in:
@@ -341,7 +341,7 @@ $(GOLINTER): $(TOOLSDIR)/.golangci-lint-$(GOLINTER_VERSION)
|
||||
$(TOOLSDIR)/.golangci-lint-$(GOLINTER_VERSION):
|
||||
mkdir -p $(TOOLSDIR)/bin
|
||||
rm -f $(TOOLSDIR)/.golangci-lint-*
|
||||
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(TOOLSDIR)/bin $(GOLINTER_VERSION)
|
||||
curl -sSfL https://golangci-lint.run/install.sh | sh -s -- -b $(TOOLSDIR)/bin $(GOLINTER_VERSION)
|
||||
$(GOLINTER) version
|
||||
touch $@
|
||||
|
||||
|
||||
Reference in New Issue
Block a user