b417ad11a0
use if let instead of a map with only sideeffects
...
Reasons:
- Map is usually intended for transforming a value, and as is not
idiomatically used for only doing side-effects and control flow.
Signed-off-by: Perma Alesheikh <me@prma.dev >
2024-01-09 22:10:28 +01:00
0f097fe293
remove double referencing
...
Reasons:
- The compiler will immediately dereference the referenced reference.
Signed-off-by: Perma Alesheikh <me@prma.dev >
2024-01-09 22:09:02 +01:00
945c567f35
remove reference over trait implemented type
...
Reasons:
- String already implement the AsRef<str>.
Signed-off-by: Perma Alesheikh <me@prma.dev >
2024-01-09 22:08:41 +01:00
2ef477c225
remove needless update using default
...
Reasons:
- Every field is either turned-off entirely or assigned a value when it
needs one.
- Avoids the situation when a new field is introduced and is assigned a
default value when it is not desired.
Signed-off-by: Perma Alesheikh <me@prma.dev >
2024-01-09 22:07:37 +01:00
54287d40b8
replace into implementation with from
...
Reasons:
- From Implementation also implements Into trait.
- Adhere to the recommendation by the Into trait's comments.
Signed-off-by: Perma Alesheikh <me@prma.dev >
2024-01-09 22:04:26 +01:00
bd1ac45a58
remove empty string from println call
2024-01-09 22:02:09 +01:00
0ff940871b
use char when replacing a single character
...
Reasons:
- More idiomatic use of string.
Considering that they are constants, I don't anticipate any performance
gains related to heap-allocation.
Signed-off-by: Perma Alesheikh <me@prma.dev >
2024-01-09 21:55:20 +01:00
f7a7937cb1
use as_deref instead of as_ref for account.name
...
Reasons:
- More concise.
- Avoids the need for map(String::str).
Signed-off-by: Perma Alesheikh <me@prma.dev >
2024-01-09 21:54:21 +01:00
59fefd7c78
use or instead of or_else
...
Reasons:
- Closure is not needed.
- Makes it more concise.
Signed-off-by: Perma Alesheikh <me@prma.dev >
2024-01-09 21:49:33 +01:00
8016ecb5a0
define SendmailConfig once
...
Reasons:
- Makes the declaration more concicse.
- Avoids the mutation.
Signed-off-by: Perma Alesheikh <me@prma.dev >
2024-01-09 21:42:28 +01:00
6fcdf7ea10
fix bad prompt_passwd for pgp config
2024-01-09 21:37:53 +01:00
6f9f75cfd2
plug autoconfig to imap and smtp wizards
2024-01-09 21:36:17 +01:00
b0d7e773dc
renamed sync feature to account-sync, put wizard stuff under feature
2024-01-09 09:28:45 +01:00
921194da5c
remove empty str inside println
...
Reasons:
- Functionally it has the same result.
Signed-off-by: Perma Alesheikh <me@prma.dev >
2024-01-08 23:02:03 +01:00
95eed65193
use empty ok instead of wrapping empty expression
...
Reasons:
- It is more readable since the evaluated result is more explicit.
Signed-off-by: Perma Alesheikh <me@prma.dev >
2024-01-08 23:01:52 +01:00
3cca9ac9e8
use static instead of const for lazy values
...
Reasons:
- Every time a const is referenced, a new instance of the Cell, Mutex,
or AtomicXxxx is created, negating the purpose of using these types.
To address this issue, the const value should be stored within
a static item.
Signed-off-by: Perma Alesheikh <me@prma.dev >
2024-01-08 23:01:41 +01:00
d2ad386eaa
use as as_deref instead of as_ref and mapping on str
...
Reasons:
- Make the code more direct and concise.
Signed-off-by: Perma Alesheikh <me@prma.dev >
2024-01-08 23:01:26 +01:00
6173495cb6
use iter instead of into_iter
...
Reasons:
- This is functionally similar to into_iter since it is reference.
- It does not consume the list.
Signed-off-by: Perma Alesheikh <me@prma.dev >
2024-01-08 23:01:03 +01:00
161f35d20e
clean cargo features
2024-01-08 10:34:37 +01:00
819bdc84b3
fix features warns and save sent message copy option
2024-01-08 00:33:07 +01:00
a6b863759c
add one cargo feature per backend feature
2024-01-07 23:48:45 +01:00
45ce05ec4d
fix typos
2024-01-05 21:59:41 +01:00
38c8a67ddd
fix: remove printer message from completions command
...
this way the output command can be used to source completion
2024-01-05 21:56:47 +01:00
70fad9b1fd
fix default command
2024-01-03 22:49:39 +01:00
0352e91e36
improve backend features management for every command
2024-01-03 12:58:44 +01:00
a8c6756f56
fix envelope listing
2024-01-02 12:21:12 +01:00
37c352ea7f
Merge pull request #463 from w3irdrobot/sendmail-fix
...
allow account.sendmail when sendmail feature is on
2024-01-01 22:32:51 +01:00
6b6e5cb1fa
fix ambiguous email export
2024-01-01 15:57:30 -05:00
77206b2326
allow account.sendmail when sendmail feature is on
2024-01-01 13:49:31 -05:00
be877f0b3e
fix linux, macos and windows release builds
2024-01-01 00:27:45 +01:00
a59d1ca2c6
refactor imap and smtp encryption options
2023-12-30 22:38:25 +01:00
2351cfdd28
fix redundant copy saved
2023-12-20 16:43:33 +01:00
cd7cecca6e
fix message send save copy
2023-12-20 14:55:09 +01:00
9838854ec0
remove obsolete unit tests
2023-12-20 08:17:06 +01:00
f398eb0d30
turn folder arg into flag for message copy, move and delete cmds
2023-12-19 15:37:23 +01:00
c11f00d791
fix message and template send stdin issues
2023-12-19 15:36:56 +01:00
6942c59097
improve folder alias management
2023-12-15 22:54:13 +01:00
bcef05a54c
replace folder arg by flag for watch cmd
2023-12-15 08:52:17 +01:00
d6bf407653
move watch command from folder to envelope
2023-12-14 14:12:25 +01:00
7fccdd822a
init folder watch command
2023-12-14 12:13:08 +01:00
24bb6f10d7
fix broken link in readme
2023-12-12 15:25:49 +01:00
3e3f111d3b
fix typos
2023-12-11 22:01:48 +01:00
2e0ec913cf
refactor configs to match new nested api from lib
2023-12-11 18:38:00 +01:00
8e05be7f77
apply pr #461 due to conflicts, bump pimalaya crates
2023-12-10 22:01:49 +01:00
203ed2f917
fix editor command hanging, add --preview flag for msg read cmd
2023-12-09 22:06:08 +01:00
04e721d591
adjust api, test commands with a greenmail instance
2023-12-09 09:38:33 +01:00
ef3214f36f
clean doc
2023-12-08 12:18:18 +01:00
fff11fbe20
refactor template with clap derive api
2023-12-07 22:37:28 +01:00
b28f12c367
refactor attachment with clap derive api
2023-12-07 21:59:12 +01:00
b8ef771614
refactor message with clap derive api (part 2)
2023-12-07 18:50:46 +01:00
Perma Alesheikh