This is to out-source the table making in terminal to the external
library.
I removed the in-house table implementation since it is not used any
more, and had been replaced by comfy-table, we use this instead.
I also have reimplemented table_max_width since new implementation
removed max width , with the new implemetation it will work again.
Signed-off-by: Perma Alesheikh <me@prma.dev>
In order to reduce our dependencies, we are replacing the dependencies
that use console_rs with those that use crossterm.
This commit will completely replace dialoguer with inquire.
Signed-off-by: Perma Alesheikh <me@prma.dev>
Considering that "dialoguer" uses "console" backend library, and the
future of himalaya is reliant on "crossterm", we are moving from
dialoguer, to inquire.
This commit is going to include some experimental changes to one file.
Signed-off-by: Perma Alesheikh <me@prma.dev>
Since Himalaya is intended to be ran as a CLI in the terminal emulator
environment, their user experience could vastly improve with better and
more colorful error messages and logging.
This change will replace more minimal libraries for error-reporting/han-
dling with their more advanced counterparts.
Since these crates have tight integrations, this commit will change both
in one shot.
Also we have don't need env_logger any more. So I also have removed that
guy as well.
Signed-off-by: Perma Alesheikh <me@prma.dev>
Reasons:
- Avoid unnecessary conversion, since into is called on an String value
when String is expected, anyway.
Signed-off-by: Perma Alesheikh <me@prma.dev>
Reasons:
- Filter_map will run forever if iterator only returns Err with lines.
This is a possibility for "lines" iterators.
- Map_while will break the mapping the moment the iterator returns error.
Signed-off-by: Perma Alesheikh <me@prma.dev>
Clément DOUIN