github/himalaya
1
0
Fork 0
mirror of https://github.com/pimalaya/himalaya.git synced 2026-06-16 20:57:53 +08:00
Code Issues Packages Projects Releases Wiki Activity
598 Commits 1 Branch 44 Tags
8741508413774d0fb849831ce0aa024b4a933744
Commit Graph

598 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Clément DOUIN 8741508413 removed github issue template 
GitHub Issues have been definitely closed, so the template does not
make sense anymore.
 2024-02-04 21:03:16 +01:00
Clément DOUIN dd7e1a02be improve pre and post edit choices interaction 2024-02-04 12:13:14 +01:00
Clément DOUIN 35c1453863 added wizard warning about google passwords 2024-02-04 11:36:11 +01:00
Clément DOUIN a945e1bf2f make watch hooks cumulative 2024-02-03 22:30:15 +01:00
Clément DOUIN 83306d5f6a fix pgp unit test 2024-01-28 08:42:18 +01:00
Clément DOUIN e5cf39b351 release v1.0.0-beta.2 v1.0.0-beta.2 2024-01-27 22:49:29 +01:00
Clément DOUIN 34a0978588 fix dead links and config sample 2024-01-27 22:47:06 +01:00
Clément DOUIN 7cdfecd7dd fix changelog and contributing guide typos 2024-01-27 11:28:26 +01:00
Clément DOUIN b1cc03d2c7 fix readme typo (part 2) 2024-01-27 11:24:23 +01:00
Clément DOUIN 72c3e55bba fix readme typo 2024-01-27 11:21:59 +01:00
Clément DOUIN 4f9705952a refactor new backend api 2024-01-27 11:15:03 +01:00
Clément DOUIN 16266dbc0b fix message save and send prevented due to clap help 2024-01-22 12:03:33 +01:00
Clément DOUIN 39d2dec9e8 fix readme typo 2024-01-22 10:42:26 +01:00
Clément DOUIN 4d288b9d51 fix missing notmuch backend features, improve docs 2024-01-22 10:39:06 +01:00
Clément DOUIN 8cebdf9e90 remove account config from context builder new fn 2024-01-21 22:09:14 +01:00
Clément DOUIN 3137e1e851 add back notmuch features (part 1) 2024-01-21 15:59:03 +01:00
Clément DOUIN a700f358fb clean autoconfig discovery 2024-01-18 22:01:22 +01:00
Clément DOUIN 7d4ad9c1d9 replaced autoconfig by custom email-lib account discovery module 2024-01-18 11:59:27 +01:00
Clément DOUIN 2342a83d0d deny unknown fields on toml account config 2024-01-15 22:34:30 +01:00
Clément DOUIN 7eba3a5186 generate one autoconfig per email address 2024-01-15 15:27:14 +01:00
Clément DOUIN 1246be8a5b fix wizard serialization issues 2024-01-12 10:16:43 +01:00
Perma Alesheikh a15e2c0442 allow module inception 
Reasons:
- The containing module is already reexported, so repitition in
  namespace is unnecessary.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 22:13:31 +01:00
Perma Alesheikh fc59757a9d remove another unnecessary conversion 
Reasons:
- Avoid unnecessary conversion, since into is called on an String value
  when String is expected, anyway.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 22:12:57 +01:00
Perma Alesheikh 87eac50eb7 remove comparison with boolean value 
Reasons:
- The bool value itself is enough for the filter expression.
- Simplifies the expression.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 22:12:46 +01:00
Perma Alesheikh 0b066b7529 remove unnessary conversions to itself 
Reasons:
- Remove unnecessary steps. into() is called on String when the expected
  type is already String.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 22:12:31 +01:00
Perma Alesheikh a6440aaa27 remove unnecessary into_owned 
Reasons:
- Remove unnecessary step.
- Avoid allocation when not needed.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 22:12:09 +01:00
Perma Alesheikh 2af1936ef8 use map_while to count for always err case. 
Reasons:
- Filter_map will run forever if iterator only returns Err with lines.
  This is a possibility for "lines" iterators.
- Map_while will break the mapping the moment the iterator returns error.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 22:11:23 +01:00
Perma Alesheikh b417ad11a0 use if let instead of a map with only sideeffects 
Reasons:
- Map is usually intended for transforming a value, and as is not
  idiomatically used for only doing side-effects and control flow.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 22:10:28 +01:00
Perma Alesheikh 0f097fe293 remove double referencing 
Reasons:
- The compiler will immediately dereference the referenced reference.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 22:09:02 +01:00
Perma Alesheikh 945c567f35 remove reference over trait implemented type 
Reasons:
- String already implement the AsRef<str>.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 22:08:41 +01:00
Perma Alesheikh 2ef477c225 remove needless update using default 
Reasons:
- Every field is either turned-off entirely or assigned a value when it
  needs one.
- Avoids the situation when a new field is introduced and is assigned a
  default value when it is not desired.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 22:07:37 +01:00
Perma Alesheikh 54287d40b8 replace into implementation with from 
Reasons:
- From Implementation also implements Into trait.
- Adhere to the recommendation by the Into trait's comments.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 22:04:26 +01:00
Clément DOUIN bd1ac45a58 remove empty string from println call 2024-01-09 22:02:09 +01:00
Perma Alesheikh 0ff940871b use char when replacing a single character 
Reasons:
- More idiomatic use of string.

Considering that they are constants, I don't anticipate any performance
gains related to heap-allocation.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 21:55:20 +01:00
Perma Alesheikh f7a7937cb1 use as_deref instead of as_ref for account.name 
Reasons:
- More concise.
- Avoids the need for map(String::str).

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 21:54:21 +01:00
Perma Alesheikh 59fefd7c78 use or instead of or_else 
Reasons:
- Closure is not needed.
- Makes it more concise.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 21:49:33 +01:00
Perma Alesheikh 8016ecb5a0 define SendmailConfig once 
Reasons:
- Makes the declaration more concicse.
- Avoids the mutation.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-09 21:42:28 +01:00
Clément DOUIN 6fcdf7ea10 fix bad prompt_passwd for pgp config 2024-01-09 21:37:53 +01:00
Clément DOUIN 6f9f75cfd2 plug autoconfig to imap and smtp wizards 2024-01-09 21:36:17 +01:00
Clément DOUIN b0d7e773dc renamed sync feature to account-sync, put wizard stuff under feature 2024-01-09 09:28:45 +01:00
Perma Alesheikh 921194da5c remove empty str inside println 
Reasons:
- Functionally it has the same result.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-08 23:02:03 +01:00
Perma Alesheikh 95eed65193 use empty ok instead of wrapping empty expression 
Reasons:
- It is more readable since the evaluated result is more explicit.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-08 23:01:52 +01:00
Perma Alesheikh 3cca9ac9e8 use static instead of const for lazy values 
Reasons:
- Every time a const is referenced, a new instance of the Cell, Mutex,
  or AtomicXxxx is created, negating the purpose of using these types.
  To address this issue, the const value should be stored within
  a static item.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-08 23:01:41 +01:00
Perma Alesheikh d2ad386eaa use as as_deref instead of as_ref and mapping on str 
Reasons:
- Make the code more direct and concise.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-08 23:01:26 +01:00
Perma Alesheikh 6173495cb6 use iter instead of into_iter 
Reasons:
- This is functionally similar to into_iter since it is reference.
- It does not consume the list.

Signed-off-by: Perma Alesheikh <me@prma.dev>
 2024-01-08 23:01:03 +01:00
Clément DOUIN 42226abc9c improve contributing section 2024-01-08 22:47:08 +01:00
Clément DOUIN 161f35d20e clean cargo features 2024-01-08 10:34:37 +01:00
Clément DOUIN 819bdc84b3 fix features warns and save sent message copy option 2024-01-08 00:33:07 +01:00
Clément DOUIN a6b863759c add one cargo feature per backend feature 2024-01-07 23:48:45 +01:00
Clément DOUIN 9ffac16e05 adjust readme matrix workspace name 2024-01-06 08:51:51 +01:00