mirror of
https://github.com/project-zot/zot.git
synced 2026-06-17 21:17:58 +08:00
mottetm
483c869920
fix: metrics authorization middleware bleed (#3182) Fixes `extension_metrics_disabled.go` to correctly isolate the authz middleware when the metrics extension is disabled. Signed-off-by: Matthieu Mottet <m.mottet@outlook.com>
37 lines
1.0 KiB
Go
37 lines
1.0 KiB
Go
//go:build !metrics
|
|
// +build !metrics
|
|
|
|
package extensions
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"github.com/gorilla/mux"
|
|
|
|
"zotregistry.dev/zot/pkg/api/config"
|
|
zcommon "zotregistry.dev/zot/pkg/common"
|
|
"zotregistry.dev/zot/pkg/extensions/monitoring"
|
|
"zotregistry.dev/zot/pkg/log"
|
|
)
|
|
|
|
// EnableMetricsExtension ...
|
|
func EnableMetricsExtension(config *config.Config, log log.Logger, rootDir string) {
|
|
log.Warn().Msg("skipping enabling metrics extension because given zot binary doesn't include this feature," +
|
|
"please build a binary that does so")
|
|
}
|
|
|
|
// SetupMetricsRoutes ...
|
|
func SetupMetricsRoutes(conf *config.Config, router *mux.Router,
|
|
authnFunc, authzFunc mux.MiddlewareFunc, log log.Logger, metrics monitoring.MetricServer,
|
|
) {
|
|
getMetrics := func(w http.ResponseWriter, r *http.Request) {
|
|
m := metrics.ReceiveMetrics()
|
|
zcommon.WriteJSON(w, http.StatusOK, m)
|
|
}
|
|
|
|
extRouter := router.PathPrefix("/metrics").Subrouter()
|
|
extRouter.Use(authnFunc)
|
|
extRouter.Use(authzFunc)
|
|
extRouter.Methods("GET").Handler(http.HandlerFunc(getMetrics))
|
|
}
|