mirror of
https://github.com/project-zot/zot.git
synced 2026-06-16 20:38:08 +08:00
9cc990d7ca
Initial code was contributed by Bogdan BIVOLARU <104334+bogdanbiv@users.noreply.github.com> Moved implementation from a separate db to repodb by Andrei Aaron <aaaron@luxoft.com> Not done yet: - run/test dynamodb implementation, only boltdb was tested - add additional coverage for existing functionality - add web-based APIs to toggle the stars/bookmarks on/off Initially graphql mutation was discussed for the missing API but we decided REST endpoints would be better suited for configuration feat(userdb): complete functionality for userdb integration - dynamodb rollback changes to user starred repos in case increasing the total star count fails - dynamodb increment/decrement repostars in repometa when user stars/unstars a repo - dynamodb check anonymous user permissions are working as intendend - common test handle anonymous users - RepoMeta2RepoSummary set IsStarred and IsBookmarked feat(userdb): rest api calls for toggling stars/bookmarks on/off test(userdb): blackbox tests test(userdb): move preferences tests in a different file with specific build tags feat(repodb): add is-starred and is-bookmarked fields to repo-meta - removed duplicated logic for determining if a repo is starred/bookmarked Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com> Co-authored-by: Andrei Aaron <aaaron@luxoft.com>
140 lines
4.3 KiB
Go
140 lines
4.3 KiB
Go
//go:build userprefs
|
|
// +build userprefs
|
|
|
|
package extensions_test
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/gorilla/mux"
|
|
. "github.com/smartystreets/goconvey/convey"
|
|
|
|
zerr "zotregistry.io/zot/errors"
|
|
"zotregistry.io/zot/pkg/extensions"
|
|
"zotregistry.io/zot/pkg/log"
|
|
"zotregistry.io/zot/pkg/meta/repodb"
|
|
"zotregistry.io/zot/pkg/test/mocks"
|
|
)
|
|
|
|
var ErrTestError = errors.New("TestError")
|
|
|
|
const UserprefsBaseURL = "http://127.0.0.1:8080/v2/_zot/ext/userprefs"
|
|
|
|
func TestHandlers(t *testing.T) {
|
|
log := log.NewLogger("debug", "")
|
|
mockrepoDB := mocks.RepoDBMock{}
|
|
|
|
Convey("No repo in request", t, func() {
|
|
request := httptest.NewRequest("GET", UserprefsBaseURL+"", strings.NewReader("My string"))
|
|
response := httptest.NewRecorder()
|
|
|
|
extensions.PutStar(response, request, mockrepoDB, log)
|
|
res := response.Result()
|
|
So(res.StatusCode, ShouldEqual, http.StatusBadRequest)
|
|
defer res.Body.Close()
|
|
|
|
extensions.PutBookmark(response, request, mockrepoDB, log)
|
|
res = response.Result()
|
|
So(res.StatusCode, ShouldEqual, http.StatusBadRequest)
|
|
defer res.Body.Close()
|
|
})
|
|
|
|
Convey("Empty repo in request", t, func() {
|
|
request := httptest.NewRequest("GET", UserprefsBaseURL+"?repo=", strings.NewReader("My string"))
|
|
response := httptest.NewRecorder()
|
|
|
|
extensions.PutStar(response, request, mockrepoDB, log)
|
|
res := response.Result()
|
|
So(res.StatusCode, ShouldEqual, http.StatusNotFound)
|
|
defer res.Body.Close()
|
|
|
|
extensions.PutBookmark(response, request, mockrepoDB, log)
|
|
res = response.Result()
|
|
So(res.StatusCode, ShouldEqual, http.StatusNotFound)
|
|
defer res.Body.Close()
|
|
})
|
|
|
|
Convey("ToggleStarRepo different errors", t, func() {
|
|
request := httptest.NewRequest("GET", UserprefsBaseURL+"?repo=test",
|
|
strings.NewReader("My string"))
|
|
|
|
Convey("ErrRepoMetaNotFound", func() {
|
|
mockrepoDB.ToggleStarRepoFn = func(ctx context.Context, repo string) (repodb.ToggleState, error) {
|
|
return repodb.NotChanged, zerr.ErrRepoMetaNotFound
|
|
}
|
|
|
|
mockrepoDB.ToggleBookmarkRepoFn = func(ctx context.Context, repo string) (repodb.ToggleState, error) {
|
|
return repodb.NotChanged, zerr.ErrRepoMetaNotFound
|
|
}
|
|
|
|
response := httptest.NewRecorder()
|
|
extensions.PutBookmark(response, request, mockrepoDB, log)
|
|
res := response.Result()
|
|
So(res.StatusCode, ShouldEqual, http.StatusNotFound)
|
|
defer res.Body.Close()
|
|
|
|
response = httptest.NewRecorder()
|
|
extensions.PutStar(response, request, mockrepoDB, log)
|
|
res = response.Result()
|
|
So(res.StatusCode, ShouldEqual, http.StatusNotFound)
|
|
defer res.Body.Close()
|
|
})
|
|
|
|
Convey("ErrUserDataNotAllowed", func() {
|
|
request = mux.SetURLVars(request, map[string]string{
|
|
"name": "repo",
|
|
})
|
|
|
|
mockrepoDB.ToggleBookmarkRepoFn = func(ctx context.Context, repo string) (repodb.ToggleState, error) {
|
|
return repodb.NotChanged, zerr.ErrUserDataNotAllowed
|
|
}
|
|
|
|
mockrepoDB.ToggleStarRepoFn = func(ctx context.Context, repo string) (repodb.ToggleState, error) {
|
|
return repodb.NotChanged, zerr.ErrUserDataNotAllowed
|
|
}
|
|
|
|
response := httptest.NewRecorder()
|
|
extensions.PutBookmark(response, request, mockrepoDB, log)
|
|
res := response.Result()
|
|
So(res.StatusCode, ShouldEqual, http.StatusForbidden)
|
|
defer res.Body.Close()
|
|
|
|
response = httptest.NewRecorder()
|
|
extensions.PutStar(response, request, mockrepoDB, log)
|
|
res = response.Result()
|
|
So(res.StatusCode, ShouldEqual, http.StatusForbidden)
|
|
defer res.Body.Close()
|
|
})
|
|
|
|
Convey("ErrUnexpectedError", func() {
|
|
request = mux.SetURLVars(request, map[string]string{
|
|
"name": "repo",
|
|
})
|
|
|
|
mockrepoDB.ToggleBookmarkRepoFn = func(ctx context.Context, repo string) (repodb.ToggleState, error) {
|
|
return repodb.NotChanged, ErrTestError
|
|
}
|
|
|
|
mockrepoDB.ToggleStarRepoFn = func(ctx context.Context, repo string) (repodb.ToggleState, error) {
|
|
return repodb.NotChanged, ErrTestError
|
|
}
|
|
response := httptest.NewRecorder()
|
|
extensions.PutBookmark(response, request, mockrepoDB, log)
|
|
res := response.Result()
|
|
So(res.StatusCode, ShouldEqual, http.StatusInternalServerError)
|
|
defer res.Body.Close()
|
|
|
|
response = httptest.NewRecorder()
|
|
extensions.PutStar(response, request, mockrepoDB, log)
|
|
res = response.Result()
|
|
So(res.StatusCode, ShouldEqual, http.StatusInternalServerError)
|
|
defer res.Body.Close()
|
|
})
|
|
})
|
|
}
|