mirror of
https://github.com/project-zot/zot.git
synced 2026-06-17 21:17:58 +08:00
Benoit Tigeot
d97953f101
* ci: Reduce chance of installing corrupt packages See: https://dev.to/hsbt/should-rubygemsbundler-have-a-cooldown-feature-40cp Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * ci: prevent credential leakage from checkout steps Add `persist-credentials: false` to all `actions/checkout` calls across 22 workflow files. Without this, the GitHub token used for checkout is written into `.git/config` and remains accessible to all subsequent steps and any uploaded artifacts (artipacked finding). Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * ci: prevent template injection from github context in run steps `${{ github.* }}` expressions used directly inside `run:` blocks are expanded before the shell sees them. A crafted value (e.g. a tag name containing shell metacharacters) would execute arbitrary code. Move the values into `env:` variables (e.g. GITHUB_EVENT_RELEASE_TAG_NAME, GITHUB_ACTOR) and reference them as `${VAR}` in the shell, so the runtime never interprets them as code (template-injection finding). Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * ci: prevent injection in yq commands via release tag name `${{ github.event.release.tag_name }}` was interpolated directly into yq `cmd:` inputs. A crafted tag name could inject shell commands since the expression is expanded before the action runs. Use yq's `strenv()` with an `env:` variable instead so the value is always treated as data. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * ci: pin all GitHub Actions to full commit SHAs Actions pinned to mutable tags (e.g. @v6, @main) can change under us if the upstream repo is compromised or tags are moved, enabling supply-chain attacks. Pinning to the full 40-char commit SHA locks the exact code that runs. Version tags are preserved as inline comments (e.g. # v6.0.2) for readability and Dependabot compatibility. Used `pinact` for standard tagged versions; remaining branch-based references (mikefarah/yq, jlumbroso/free-disk-space, project-stacker/stacker-build-push-action, aquasecurity/trivy-action) resolved manually via the GitHub API. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * ci: slow down GitHub Actions dependency updates to biweekly Dependabot has no native biweekly interval. Combining weekly checks with a 14-day cooldown achieves the same effect: Dependabot scans every Monday but won't open a PR for a new action version until 14 days after release, giving the ecosystem time to stabilize before we adopt it. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * ci: group all Dependabot updates into single PRs per ecosystem Without groups, Dependabot opens one PR per dependency. With `patterns: "*"`, all Go module bumps land in one PR and all GitHub Actions pin updates in another, reducing review noise. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * ci: restore credential persistence for helm-charts push `persist-credentials: false` was too broad — the helm-charts checkout uses HELM_PUSH_TOKEN specifically so the subsequent `git push` can authenticate. Only the main repo checkout should have credentials disabled. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * ci: use --password-stdin for oras login Passing the token via `-p` exposes it in process listings and debug logs. Piping via stdin is the standard secure pattern for CLI auth. Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> * ci: pin actions to versioned release SHAs jmgilman/actions-generate-checksum: v1 branch HEAD -> v1.0.1 release mikefarah/yq: arbitrary master HEAD -> v4.52.5 release Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr> --------- Signed-off-by: Benoit Tigeot <benoit.tigeot@lifen.fr>
72 lines
2.2 KiB
YAML
72 lines
2.2 KiB
YAML
name: 'Security web scan for zot'
|
|
on:
|
|
push:
|
|
branches:
|
|
- main
|
|
pull_request:
|
|
branches:
|
|
- main
|
|
release:
|
|
types:
|
|
- published
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
zap_scan:
|
|
runs-on: ubuntu-latest
|
|
name: Scan ZOT using ZAP
|
|
strategy:
|
|
matrix:
|
|
flavor: [zot-linux-amd64-minimal, zot-linux-amd64]
|
|
steps:
|
|
- name: Install go
|
|
uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0
|
|
with:
|
|
cache: false
|
|
check-latest: true
|
|
go-version: 1.25.x
|
|
- name: Checkout
|
|
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
with:
|
|
persist-credentials: false
|
|
- name: Build zot
|
|
run: |
|
|
echo "Building $FLAVOR"
|
|
cd $GITHUB_WORKSPACE
|
|
if [[ $FLAVOR == "zot-linux-amd64-minimal" ]]; then
|
|
make binary-minimal
|
|
else
|
|
make binary
|
|
fi
|
|
ls -l bin/
|
|
env:
|
|
FLAVOR: ${{ matrix.flavor }}
|
|
- name: Bringup zot server
|
|
run: |
|
|
# upload images, zot can serve OCI image layouts directly like so
|
|
mkdir /tmp/zot
|
|
skopeo copy --format=oci docker://busybox:latest oci:/tmp/zot/busybox:latest
|
|
# start zot
|
|
if [[ $FLAVOR == "zot-linux-amd64-minimal" ]]; then
|
|
./bin/${{ matrix.flavor }} serve examples/config-conformance.json &
|
|
else
|
|
./bin/${{ matrix.flavor }} serve examples/config-ui.json &
|
|
fi
|
|
# wait until service is up
|
|
while true; do x=0; curl -f http://localhost:8080/v2/ || x=1; if [ $x -eq 0 ]; then break; fi; sleep 1; done
|
|
env:
|
|
FLAVOR: ${{ matrix.flavor }}
|
|
- name: ZAP Scan Rest API
|
|
uses: zaproxy/action-baseline@de8ad967d3548d44ef623df22cf95c3b0baf8b25 # v0.15.0
|
|
with:
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
docker_name: 'ghcr.io/zaproxy/zaproxy:stable'
|
|
target: 'http://localhost:8080/v2/'
|
|
rules_file_name: '.zap/rules.tsv'
|
|
cmd_options: '-a -j'
|
|
allow_issue_writing: false
|
|
fail_action: true
|
|
artifact_name: zap_scan_${{ matrix.flavor }}
|