github/zot
1
0
Fork 0
mirror of https://github.com/project-zot/zot.git synced 2026-06-20 06:37:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(sync): fixed checking updates in remote tags digest

Browse Source 
when preserveDigest option in sync is enabled

closes: #3129

Signed-off-by: Eusebiu Petu <petu.eusebiu@gmail.com>
This commit is contained in:
Eusebiu Petu
2025-05-15 19:09:04 +03:00
parent 7291b88896
commit f0a9b1fe45
3 changed files with 306 additions and 246 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/extensions/sync/service.go
+8 -5
View File
@@ -496,16 +496,16 @@ func (service *BaseService) syncRef(ctx context.Context, localRepo string, remot
}
// get "would be" digest of image after synced.
func (service *BaseService) getLocalStoredImageDigest(ctx context.Context, repo, tag string,
func (service *BaseService) computeLocalStoredImageDigest(ctx context.Context, repo, tag string,
) (godigest.Digest, godigest.Digest, bool, error) {
var err error
var convertedDigest, remoteDigest godigest.Digest
var localDigest, remoteDigest godigest.Digest
var isConverted bool
if !service.config.PreserveDigest {
convertedDigest, remoteDigest, isConverted, err = service.remote.GetOCIDigest(ctx, repo, tag)
localDigest, remoteDigest, isConverted, err = service.remote.GetOCIDigest(ctx, repo, tag)
if err != nil {
service.log.Error().Err(err).Str("repository", repo).Str("reference", tag).
Msg("failed to get upstream image manifest details")
@@ -520,9 +520,12 @@ func (service *BaseService) getLocalStoredImageDigest(ctx context.Context, repo,
return "", "", false, err
}
// preserve digest is true, so the local digest is same as remote
localDigest = remoteDigest
}
return convertedDigest, remoteDigest, isConverted, nil
return localDigest, remoteDigest, isConverted, nil
}
func (service *BaseService) syncImage(ctx context.Context, localRepo, remoteRepo, tag string,
@@ -543,7 +546,7 @@ func (service *BaseService) syncImage(ctx context.Context, localRepo, remoteRepo
return err
}
localDigest, remoteDigest, isConverted, err = service.getLocalStoredImageDigest(ctx, remoteRepo, tag)
localDigest, remoteDigest, isConverted, err = service.computeLocalStoredImageDigest(ctx, remoteRepo, tag)
if err != nil {
return err
}