chore: update golangci-lint and fix all issues (#3575)

* chore: Update golangci-lint

Signed-off-by: Lars Francke <git@lars-francke.de>

* chore: fix all golangci-lint issues

- Remove deprecated `// +build` tags
- Fix godoclint, modernize, wsl_v5, govet, lll, gci, noctx issues
- Update linter configuration
- Modernize code to use Go 1.22+ features (for range N, slices.Contains, etc.)
- Update make check lint the privileged tests

Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>

---------

Signed-off-by: Lars Francke <git@lars-francke.de>
Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
Co-authored-by: Lars Francke <git@lars-francke.de>

pkg/test/auth/bearer.go

@@ -147,7 +147,7 @@ func ParseBearerAuthHeader(authHeaderRaw string) *AuthHeader {
 	matches := re.FindAllStringSubmatch(authHeaderRaw, -1)
 	matchmap := make(map[string]string)
 
-	for i := 0; i < len(matches); i++ {
+	for i := range matches {
 		matchmap[matches[i][1]] = matches[i][2]
 	}
 

pkg/test/auth/oidc.go

@@ -18,7 +18,7 @@ func MockOIDCRun() (*mockoidc.MockOIDC, error) {
 	mockServer, _ := mockoidc.NewServer(rsaKey)
 
 	// Create the net.Listener, kernel will chose a valid port
-	listener, _ := net.Listen("tcp", "127.0.0.1:0")
+	listener, _ := net.Listen("tcp", "127.0.0.1:0") //nolint: noctx
 
 	bearerMiddleware := func(next http.Handler) http.Handler {
 		return http.HandlerFunc(func(response http.ResponseWriter, req *http.Request) {