chore: update golangci-lint and fix all issues (#3575)

* chore: Update golangci-lint

Signed-off-by: Lars Francke <git@lars-francke.de>

* chore: fix all golangci-lint issues

- Remove deprecated `// +build` tags
- Fix godoclint, modernize, wsl_v5, govet, lll, gci, noctx issues
- Update linter configuration
- Modernize code to use Go 1.22+ features (for range N, slices.Contains, etc.)
- Update make check lint the privileged tests

Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>

---------

Signed-off-by: Lars Francke <git@lars-francke.de>
Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
Co-authored-by: Lars Francke <git@lars-francke.de>

pkg/debug/gqlplayground/gqlplayground.go

@@ -1,5 +1,4 @@
 //go:build debug
-// +build debug
 
 package debug
 

pkg/debug/gqlplayground/gqlplayground_disabled.go

@@ -1,5 +1,4 @@
 //go:build !debug
-// +build !debug
 
 package debug
 

pkg/debug/pprof/pprof.go

@@ -1,5 +1,4 @@
 //go:build profile
-// +build profile
 
 package pprof
 

pkg/debug/pprof/pprof_disabled.go

@@ -1,5 +1,4 @@
 //go:build !profile
-// +build !profile
 
 package pprof
 

pkg/debug/pprof/pprof_test.go

@@ -1,5 +1,4 @@
 //go:build profile
-// +build profile
 
 package pprof_test
 

pkg/debug/swagger/swagger.go

@@ -1,5 +1,4 @@
 //go:build debug
-// +build debug
 
 // @contact.name API Support
 // @contact.url http://www.swagger.io/support
@@ -7,12 +6,14 @@
 
 package debug
 
+//nolint:gci // import order required by swaggo
 import (
 	"github.com/gorilla/mux"
 	httpSwagger "github.com/swaggo/http-swagger"
 
 	"zotregistry.dev/zot/v2/pkg/api/config"
 	"zotregistry.dev/zot/v2/pkg/log" //nolint:goimports
+
 	// as required by swaggo.
 	_ "zotregistry.dev/zot/v2/swagger"
 )

pkg/debug/swagger/swagger_disabled.go

@@ -1,5 +1,4 @@
 //go:build !debug
-// +build !debug
 
 // @contact.name API Support
 // @contact.url http://www.swagger.io/support