chore: update golangci-lint and fix all issues (#3575)

* chore: Update golangci-lint

Signed-off-by: Lars Francke <git@lars-francke.de>

* chore: fix all golangci-lint issues

- Remove deprecated `// +build` tags
- Fix godoclint, modernize, wsl_v5, govet, lll, gci, noctx issues
- Update linter configuration
- Modernize code to use Go 1.22+ features (for range N, slices.Contains, etc.)
- Update make check lint the privileged tests

Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>

---------

Signed-off-by: Lars Francke <git@lars-francke.de>
Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
Co-authored-by: Lars Francke <git@lars-francke.de>
This commit is contained in:
Andrei Aaron
2025-11-22 23:36:48 +02:00
committed by GitHub
parent 566286ae42
commit da426850e7
242 changed files with 811 additions and 1010 deletions
+5 -21
View File
@@ -1,6 +1,8 @@
package compat
import (
"slices"
dockerList "github.com/distribution/distribution/v3/manifest/manifestlist"
docker "github.com/distribution/distribution/v3/manifest/schema2"
v1 "github.com/opencontainers/image-spec/specs-go/v1"
@@ -22,13 +24,7 @@ func CompatibleManifestMediaTypes() []string {
}
func IsCompatibleManifestMediaType(mediatype string) bool {
for _, mt := range CompatibleManifestMediaTypes() {
if mt == mediatype {
return true
}
}
return false
return slices.Contains(CompatibleManifestMediaTypes(), mediatype)
}
func CompatibleManifestListMediaTypes() []string {
@@ -36,13 +32,7 @@ func CompatibleManifestListMediaTypes() []string {
}
func IsCompatibleManifestListMediaType(mediatype string) bool {
for _, mt := range CompatibleManifestListMediaTypes() {
if mt == mediatype {
return true
}
}
return false
return slices.Contains(CompatibleManifestListMediaTypes(), mediatype)
}
func CompatibleConfigMediaTypes() []string {
@@ -50,13 +40,7 @@ func CompatibleConfigMediaTypes() []string {
}
func IsCompatibleConfigMediaType(mediatype string) bool {
for _, mt := range CompatibleConfigMediaTypes() {
if mt == mediatype {
return true
}
}
return false
return slices.Contains(CompatibleConfigMediaTypes(), mediatype)
}
func Validate(body []byte, mediaType string) ([]v1.Descriptor, error) {