refactor(authz): use a struct for user access control info operations (#1682)

fix(authz): fix isAdmin not using groups to determine if a user is admin.
fix(authz): return 401 instead of 403

403 is correct as per HTTP spec
However authz is not part of dist-spec and clients know only about 401
So this is a compromise.

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>

pkg/extensions/search/resolver.go

@@ -26,7 +26,7 @@ import (
 	"zotregistry.io/zot/pkg/extensions/search/pagination"
 	"zotregistry.io/zot/pkg/log"
 	mTypes "zotregistry.io/zot/pkg/meta/types"
-	localCtx "zotregistry.io/zot/pkg/requestcontext"
+	reqCtx "zotregistry.io/zot/pkg/requestcontext"
 	"zotregistry.io/zot/pkg/storage"
 )
 
@@ -1108,7 +1108,7 @@ func deleteElementAt(slice []*string, i int) []*string {
 
 func expandedRepoInfo(ctx context.Context, repo string, metaDB mTypes.MetaDB, cveInfo cveinfo.CveInfo, log log.Logger,
 ) (*gql_generated.RepoInfo, error) {
-	if ok, err := localCtx.RepoIsUserAvailable(ctx, repo); !ok || err != nil {
+	if ok, err := reqCtx.RepoIsUserAvailable(ctx, repo); !ok || err != nil {
 		log.Info().Err(err).Str("repository", repo).Bool("availability", ok).Msg("resolver: repo user availability")
 
 		return &gql_generated.RepoInfo{}, nil //nolint:nilerr // don't give details to a potential attacker

pkg/extensions/search/resolver_test.go

@@ -22,7 +22,7 @@ import (
 	"zotregistry.io/zot/pkg/log"
 	"zotregistry.io/zot/pkg/meta/boltdb"
 	mTypes "zotregistry.io/zot/pkg/meta/types"
-	localCtx "zotregistry.io/zot/pkg/requestcontext"
+	reqCtx "zotregistry.io/zot/pkg/requestcontext"
 	"zotregistry.io/zot/pkg/storage"
 	"zotregistry.io/zot/pkg/test/mocks"
 )
@@ -3584,15 +3584,13 @@ func TestExpandedRepoInfo(t *testing.T) {
 	})
 
 	Convey("Access error", t, func() {
-		authzCtxKey := localCtx.GetContextKey()
-		acCtxUser := localCtx.AccessControlContext{
-			ReadGlobPatterns: map[string]bool{
-				"repo": false,
-			},
-			Username: "user",
-		}
+		userAc := reqCtx.NewUserAccessControl()
+		userAc.SetUsername("user")
+		userAc.SetGlobPatterns("read", map[string]bool{
+			"repo": false,
+		})
 
-		ctx := context.WithValue(context.Background(), authzCtxKey, acCtxUser)
+		ctx := userAc.DeriveContext(context.Background())
 
 		responseContext := graphql.WithResponseContext(ctx, graphql.DefaultErrorPresenter,
 			graphql.DefaultRecover)