github/zot
1
0
Fork 0
mirror of https://github.com/project-zot/zot.git synced 2026-06-16 04:17:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(shutdown): fix crash when shutting down before server and task scheduler have started. (#2148)

Browse Source 
init shutdown routine after controller.Init()
check for nil values before stopping http server and task scheduler.

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
This commit is contained in:
peusebiu
2024-01-06 03:50:48 +02:00
committed by GitHub
parent 59f41ac17d
commit a46e10269a
3 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/api/controller.go
+8 -3
View File
@@ -370,13 +370,18 @@ func (c *Controller) LoadNewConfig(newConfig *config.Config) {
func (c *Controller) Shutdown() {
c.StopBackgroundTasks()
ctx := context.Background()
_ = c.Server.Shutdown(ctx)
if c.Server != nil {
ctx := context.Background()
_ = c.Server.Shutdown(ctx)
}
}
// Will stop scheduler and wait for all tasks to finish their work.
func (c *Controller) StopBackgroundTasks() {
c.taskScheduler.Shutdown()
if c.taskScheduler != nil {
c.taskScheduler.Shutdown()
}
}
func (c *Controller) StartBackgroundTasks() {