From 873d4a3eeb18756c7afca2b9fae2fe8d75c9039f Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 19 May 2026 01:51:09 +0000 Subject: [PATCH] test(sync): replace cleanup retry magic numbers with constants Agent-Logs-Url: https://github.com/project-zot/zot/sessions/a8131207-64f5-4461-962a-19aab205da7d Co-authored-by: rchincha <45800463+rchincha@users.noreply.github.com> --- pkg/extensions/sync/sync_test.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pkg/extensions/sync/sync_test.go b/pkg/extensions/sync/sync_test.go index 307bb05d..839b630e 100644 --- a/pkg/extensions/sync/sync_test.go +++ b/pkg/extensions/sync/sync_test.go @@ -1551,15 +1551,20 @@ func TestDockerImagesAreSkipped(t *testing.T) { // trigger config blob upstream error // remove synced image + const ( + maxRemoveRetries = 5 + removeRetryDelay = 100 * time.Millisecond + ) + downstreamImagePath := path.Join(destDir, testImage) - for retry := 0; retry < 5; retry++ { + for retry := 0; retry < maxRemoveRetries; retry++ { err = os.RemoveAll(downstreamImagePath) if err == nil || !errors.Is(err, syscall.ENOTEMPTY) { break } - time.Sleep(100 * time.Millisecond) + time.Sleep(removeRetryDelay) } So(err, ShouldBeNil)