Report unknown keys when parsing configuration files

Report missing mandatory ldap keys

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>

pkg/api/config/config.go

@@ -7,9 +7,7 @@ import (
 	"github.com/getlantern/deepcopy"
 	distspec "github.com/opencontainers/distribution-spec/specs-go"
 	"github.com/spf13/viper"
-	"zotregistry.io/zot/errors"
 	extconf "zotregistry.io/zot/pkg/extensions/config"
-	"zotregistry.io/zot/pkg/log"
 	"zotregistry.io/zot/pkg/storage"
 )
 
@@ -167,20 +165,6 @@ func (c *Config) Sanitize() *Config {
 	return sanitizedConfig
 }
 
-func (c *Config) Validate(log log.Logger) error {
-	// LDAP configuration
-	if c.HTTP.Auth != nil && c.HTTP.Auth.LDAP != nil {
-		l := c.HTTP.Auth.LDAP
-		if l.UserAttribute == "" {
-			log.Error().Str("userAttribute", l.UserAttribute).Msg("invalid LDAP configuration")
-
-			return errors.ErrLDAPConfig
-		}
-	}
-
-	return nil
-}
-
 // LoadAccessControlConfig populates config.AccessControl struct with values from config.
 func (c *Config) LoadAccessControlConfig(viperInstance *viper.Viper) error {
 	if c.HTTP.RawAccessControl == nil {

pkg/api/controller.go

@@ -102,13 +102,6 @@ func DumpRuntimeParams(log log.Logger) {
 }
 
 func (c *Controller) Run(reloadCtx context.Context) error {
-	// validate configuration
-	if err := c.Config.Validate(c.Log); err != nil {
-		c.Log.Error().Err(err).Msg("configuration validation failed")
-
-		return err
-	}
-
 	// print the current configuration, but strip secrets
 	c.Log.Info().Interface("params", c.Config.Sanitize()).Msg("configuration settings")