From 6f0e05e676fae4d07a36d617490f551dd7574827 Mon Sep 17 00:00:00 2001 From: mottetm Date: Mon, 24 Nov 2025 15:51:56 +0100 Subject: [PATCH] fix: sync should be disabled when enable is false (#3579) Signed-off-by: Matthieu Mottet --- pkg/extensions/config/config.go | 3 ++- pkg/extensions/config/config_test.go | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/pkg/extensions/config/config.go b/pkg/extensions/config/config.go index d05e11bd..3764355f 100644 --- a/pkg/extensions/config/config.go +++ b/pkg/extensions/config/config.go @@ -126,7 +126,8 @@ func (e *ExtensionConfig) IsSyncEnabled() bool { // 1. Explicitly enabled (Enable == true), OR // 2. There are registries configured (enabled by default when registries exist) // This matches the behavior in root.go where Sync.Enable defaults to true when registries are present - return e.Sync != nil && ((e.Sync.Enable != nil && *e.Sync.Enable) || len(e.Sync.Registries) > 0) + return e.Sync != nil && ((e.Sync.Enable != nil && *e.Sync.Enable) || + (e.Sync.Enable == nil && len(e.Sync.Registries) > 0)) } // IsScrubEnabled checks if scrub is enabled in this extensions config. diff --git a/pkg/extensions/config/config_test.go b/pkg/extensions/config/config_test.go index c174b8b7..93dbd402 100644 --- a/pkg/extensions/config/config_test.go +++ b/pkg/extensions/config/config_test.go @@ -57,6 +57,11 @@ func buildSyncConfig(enabled bool) *config.ExtensionConfig { ext := &config.ExtensionConfig{} ext.Sync = &sync.Config{ Enable: &enabled, + Registries: []sync.RegistryConfig{ + { + URLs: []string{"localhost"}, + }, + }, } return ext