Address code review feedback: add constant for cache duration and fix bash tests

- Define certCheckCacheDuration constant for better maintainability
- Fix bash test syntax in tls_cert_reload.bats for command existence checks
- Fix function call syntax without command substitution

Co-authored-by: rchincha <45800463+rchincha@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-01 07:33:54 +00:00
parent 21654f64c1
commit 5f5c8ed586
2 changed files with 10 additions and 4 deletions
+3 -3
View File
@@ -2,12 +2,12 @@ load helpers_zot
load ../port_helper
function verify_prerequisites {
if [ ! $(command -v curl) ]; then
if ! command -v curl > /dev/null 2>&1; then
echo "you need to install curl as a prerequisite to running the tests" >&3
return 1
fi
if [ ! $(command -v openssl) ]; then
if ! command -v openssl > /dev/null 2>&1; then
echo "you need to install openssl as a prerequisite to running the tests" >&3
return 1
fi
@@ -63,7 +63,7 @@ function regenerate_server_cert() {
function setup_file() {
# Verify prerequisites are available
if ! $(verify_prerequisites); then
if ! verify_prerequisites; then
exit 1
fi