Address code review feedback: add constant for cache duration and fix bash tests

- Define certCheckCacheDuration constant for better maintainability
- Fix bash test syntax in tls_cert_reload.bats for command existence checks
- Fix function call syntax without command substitution

Co-authored-by: rchincha <45800463+rchincha@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-01 07:33:54 +00:00
parent 21654f64c1
commit 5f5c8ed586
2 changed files with 10 additions and 4 deletions
+7 -1
View File
@@ -12,6 +12,12 @@ import (
"zotregistry.dev/zot/v2/pkg/log"
)
const (
// certCheckCacheDuration is the minimum time between file stat checks when fsnotify is unavailable.
// This prevents excessive file system calls during high TLS handshake rates.
certCheckCacheDuration = 1 * time.Second
)
// CertReloader handles automatic reloading of TLS certificates without downtime.
// It monitors certificate and key files for changes and reloads them dynamically
// using a GetCertificate callback in tls.Config.
@@ -37,7 +43,7 @@ func NewCertReloader(certPath, keyPath string, logger log.Logger) (*CertReloader
certPath: certPath,
keyPath: keyPath,
log: logger,
checkCache: 1 * time.Second, // Only check file stats at most once per second
checkCache: certCheckCacheDuration,
stopWatcher: make(chan struct{}),
}