build: migrate to golang 1.23.x (#2701)

* build: migrate to golang 1.23.x

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>

* fix: golangci-lint reported errors

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>

---------

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>

pkg/api/controller.go

@@ -78,7 +78,7 @@ func NewController(appConfig *config.Config) *Controller {
 			panic("failed to get member socket")
 		}
 
-		if memberSocket == "" {
+		if memberSocketIdx < 0 || memberSocket == "" {
 			// there is a misconfiguration if the memberSocket cannot be identified
 			logger.Error().
 				Str("members", strings.Join(appConfig.Cluster.Members, ",")).

pkg/api/controller_test.go

@@ -381,7 +381,7 @@ func TestAutoPortSelection(t *testing.T) {
 				break
 			}
 
-			t.Logf(scanner.Text())
+			t.Logf("%s", scanner.Text())
 		}
 
 		So(scanner.Err(), ShouldBeNil)

pkg/api/ldap.go

@@ -61,7 +61,7 @@ func (lc *LDAPClient) Connect() error {
 					RootCAs:            lc.ClientCAs,
 				}
 
-				if lc.ClientCertificates != nil && len(lc.ClientCertificates) > 0 {
+				if len(lc.ClientCertificates) > 0 {
 					config.Certificates = lc.ClientCertificates
 				}
 
@@ -78,7 +78,7 @@ func (lc *LDAPClient) Connect() error {
 				ServerName:         lc.ServerName,
 				RootCAs:            lc.ClientCAs,
 			}
-			if lc.ClientCertificates != nil && len(lc.ClientCertificates) > 0 {
+			if len(lc.ClientCertificates) > 0 {
 				config.Certificates = lc.ClientCertificates
 			}