From 4d576a48170f997212cac2b348817467fa13f53c Mon Sep 17 00:00:00 2001 From: Ramkumar Chinchani Date: Fri, 21 Jan 2022 04:50:10 +0000 Subject: [PATCH] storage: return errors instead of panics Signed-off-by: Ramkumar Chinchani --- pkg/storage/storage_fs.go | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/pkg/storage/storage_fs.go b/pkg/storage/storage_fs.go index fa0ce04b..f4a5deaf 100644 --- a/pkg/storage/storage_fs.go +++ b/pkg/storage/storage_fs.go @@ -843,12 +843,16 @@ func (is *ImageStoreFS) PutBlobChunkStreamed(repo string, uuid string, body io.R DefaultFilePerms, ) if err != nil { - is.log.Fatal().Err(err).Msg("failed to open file") + is.log.Error().Err(err).Msg("failed to open file") + + return -1, err } defer file.Close() if _, err := file.Seek(0, io.SeekEnd); err != nil { - is.log.Fatal().Err(err).Msg("failed to seek file") + is.log.Error().Err(err).Msg("failed to seek file") + + return -1, err } n, err := io.Copy(file, body) @@ -884,12 +888,16 @@ func (is *ImageStoreFS) PutBlobChunk(repo string, uuid string, from int64, to in DefaultFilePerms, ) if err != nil { - is.log.Fatal().Err(err).Msg("failed to open file") + is.log.Error().Err(err).Msg("failed to open file") + + return -1, err } defer file.Close() if _, err := file.Seek(from, io.SeekStart); err != nil { - is.log.Fatal().Err(err).Msg("failed to seek file") + is.log.Error().Err(err).Msg("failed to seek file") + + return -1, err } n, err := io.Copy(file, body)