github/zot
1
0
Fork 0
mirror of https://github.com/project-zot/zot.git synced 2026-06-17 21:17:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(meta): fixes for LastUpdated and TaggedTimestamp (#3754)

Browse Source 
1. Parse repos without metadata in ParseStorage

The timestamp check in ParseStorage was skipping repos that exist in
storage but don't have metadata. When GetRepoLastUpdated returns zero
time (no metadata), we should always parse the repo to create its
metadata. Check if metaLastUpdated is zero before comparing timestamps.
If zero, always parse regardless of storageLastUpdated.

2. Change the logic of how LastUpdated is computed in RepoSummary

It is not the latest tagged timestamp from the available images or
the last updated image created timestamp, based on whichever is the
latest.

Signed-off-by: Andrei Aaron <andreifdaaron@gmail.com>
This commit is contained in:
Andrei Aaron
2026-02-03 21:10:35 +02:00
committed by GitHub
parent d5b1b2d25b
commit 3c8030b2c7
18 changed files with 602 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/meta/parse_test.go
+49
View File
@@ -3,6 +3,7 @@ package meta_test
import (
"context"
"encoding/json"
"errors"
"fmt"
"io"
"os"
@@ -832,6 +833,54 @@ func RunParseStorageTests(rootDir string, metaDB mTypes.MetaDB, log log.Logger)
// - defaultRepo (from default store, no prefix)
So(len(repoMetaList), ShouldEqual, 3)
})
Convey("ParseStorage should parse repos without metadata", func() {
imageStore := local.NewImageStore(rootDir, false, false,
log, monitoring.NewMetricsServer(false, log), nil, nil, nil, nil)
storeController := storage.StoreController{DefaultStore: imageStore}
// Create a repo in storage
testRepo := "repo-without-metadata"
// Ensure repo doesn't exist in metadata (clean up from previous test runs if needed)
err := metaDB.DeleteRepoMeta(testRepo)
So(err, ShouldBeNil)
// Verify GetRepoLastUpdated returns zero (repo doesn't exist in metadata)
metaLastUpdated := metaDB.GetRepoLastUpdated(testRepo)
So(metaLastUpdated.IsZero(), ShouldBeTrue)
image := CreateRandomImage()
err = WriteImageToFileSystem(image, testRepo, "tag1", storeController)
So(err, ShouldBeNil)
// Verify repo still doesn't exist in metadata (GetRepoMeta should return ErrRepoMetaNotFound)
_, err = metaDB.GetRepoMeta(ctx, testRepo)
So(err, ShouldNotBeNil)
So(errors.Is(err, zerr.ErrRepoMetaNotFound), ShouldBeTrue)
// Verify GetRepoLastUpdated still returns zero
metaLastUpdated = metaDB.GetRepoLastUpdated(testRepo)
So(metaLastUpdated.IsZero(), ShouldBeTrue)
// Parse storage - repos without metadata (zero time) are always parsed
// Note: This behavior is the same with or without the !metaLastUpdated.IsZero() guard
// because storageLastUpdated.Before(time.Time{}) is always false for valid timestamps
err = meta.ParseStorage(metaDB, storeController, log) //nolint: contextcheck
So(err, ShouldBeNil)
// Verify repo metadata was created
repoMeta, err := metaDB.GetRepoMeta(ctx, testRepo)
So(err, ShouldBeNil)
So(repoMeta.Name, ShouldEqual, testRepo)
So(repoMeta.Tags, ShouldContainKey, "tag1")
// Verify GetRepoLastUpdated now returns a non-zero time
metaLastUpdated = metaDB.GetRepoLastUpdated(testRepo)
So(metaLastUpdated.IsZero(), ShouldBeFalse)
})
}
func TestGetSignatureLayersInfo(t *testing.T) {