coverage: add unit test cases

pkg/cli/root_test.go

@@ -1,6 +1,7 @@
 package cli_test
 
 import (
+	"io/ioutil"
 	"os"
 	"testing"
 
@@ -12,29 +13,60 @@ func TestUsage(t *testing.T) {
 	oldArgs := os.Args
 	defer func() { os.Args = oldArgs }()
 
-	Convey("Test Usage", t, func(c C) {
+	Convey("Test usage", t, func(c C) {
 		os.Args = []string{"cli_test", "help"}
 		err := cli.NewRootCmd().Execute()
 		So(err, ShouldBeNil)
 	})
+
+	Convey("Test version", t, func(c C) {
+		os.Args = []string{"cli_test", "--version"}
+		err := cli.NewRootCmd().Execute()
+		So(err, ShouldBeNil)
+	})
 }
 
 func TestServe(t *testing.T) {
 	oldArgs := os.Args
 	defer func() { os.Args = oldArgs }()
 
-	Convey("Test Usage", t, func(c C) {
+	Convey("Test serve help", t, func(c C) {
 		os.Args = []string{"cli_test", "serve", "-h"}
 		err := cli.NewRootCmd().Execute()
 		So(err, ShouldBeNil)
 	})
+
+	Convey("Test serve config", t, func(c C) {
+		Convey("unknown config", func(c C) {
+			os.Args = []string{"cli_test", "serve", "/tmp/x"}
+			So(func() { _ = cli.NewRootCmd().Execute() }, ShouldPanic)
+		})
+
+		Convey("non-existent config", func(c C) {
+			os.Args = []string{"cli_test", "serve", "/tmp/x.yaml"}
+			So(func() { _ = cli.NewRootCmd().Execute() }, ShouldPanic)
+		})
+
+		Convey("bad config", func(c C) {
+			tmpfile, err := ioutil.TempFile("", "zot-test*.json")
+			So(err, ShouldBeNil)
+			defer os.Remove(tmpfile.Name()) // clean up
+			content := []byte(`{"log":{}}`)
+			_, err = tmpfile.Write(content)
+			So(err, ShouldBeNil)
+			err = tmpfile.Close()
+			So(err, ShouldBeNil)
+			os.Args = []string{"cli_test", "serve", tmpfile.Name()}
+			So(func() { _ = cli.NewRootCmd().Execute() }, ShouldPanic)
+		})
+	})
 }
 
 func TestGC(t *testing.T) {
 	oldArgs := os.Args
 	defer func() { os.Args = oldArgs }()
 
-	Convey("Test Usage", t, func(c C) {
+	Convey("Test gc", t, func(c C) {
 		os.Args = []string{"cli_test", "garbage-collect", "-h"}
 		err := cli.NewRootCmd().Execute()
 		So(err, ShouldBeNil)

pkg/storage/storage_test.go

@@ -1,16 +1,21 @@
 package storage_test
 
 import (
+	"bytes"
+	_ "crypto/sha256"
+	"encoding/json"
 	"io/ioutil"
 	"os"
 	"testing"
 
 	"github.com/anuvu/zot/pkg/storage"
+	godigest "github.com/opencontainers/go-digest"
+	ispec "github.com/opencontainers/image-spec/specs-go/v1"
 	"github.com/rs/zerolog"
 	. "github.com/smartystreets/goconvey/convey"
 )
 
-func TestRepoLayout(t *testing.T) {
+func TestAPIs(t *testing.T) {
 	dir, err := ioutil.TempDir("", "oci-repo-test")
 	if err != nil {
 		panic(err)
@@ -35,7 +40,91 @@ func TestRepoLayout(t *testing.T) {
 
 		Convey("Validate repo", func() {
 			v, err := il.ValidateRepo(repoName)
+			So(err, ShouldBeNil)
 			So(v, ShouldEqual, true)
+		})
+
+		Convey("Get repos", func() {
+			v, err := il.GetRepositories()
+			So(err, ShouldBeNil)
+			So(v, ShouldNotBeEmpty)
+		})
+
+		Convey("Get image tags", func() {
+			v, err := il.GetImageTags("test")
+			So(err, ShouldBeNil)
+			So(v, ShouldBeEmpty)
+		})
+
+		Convey("New blob upload", func() {
+			v, err := il.NewBlobUpload("test")
+			So(err, ShouldBeNil)
+			So(v, ShouldNotBeEmpty)
+
+			Convey("Get blob upload", func() {
+				b, err := il.GetBlobUpload("test", "invalid")
+				So(err, ShouldNotBeNil)
+				So(b, ShouldEqual, -1)
+
+				b, err = il.GetBlobUpload("test", v)
+				So(err, ShouldBeNil)
+				So(b, ShouldBeGreaterThanOrEqualTo, 0)
+
+				b, err = il.BlobUploadInfo("test", v)
+				So(err, ShouldBeNil)
+				So(b, ShouldBeGreaterThanOrEqualTo, 0)
+
+				content := []byte("test-data")
+				buf := bytes.NewBuffer(content)
+				l := buf.Len()
+				d := godigest.FromBytes(content)
+				b, err = il.PutBlobChunk("test", v, 0, int64(l), buf)
+				So(err, ShouldBeNil)
+				So(b, ShouldEqual, l)
+
+				err = il.FinishBlobUpload("test", v, buf, d.String())
+				So(err, ShouldBeNil)
+				So(b, ShouldEqual, l)
+
+				_, _, err = il.CheckBlob("test", d.String(), "application/vnd.oci.image.layer.v1.tar+gzip")
+				So(err, ShouldBeNil)
+
+				_, _, err = il.GetBlob("test", d.String(), "application/vnd.oci.image.layer.v1.tar+gzip")
+				So(err, ShouldBeNil)
+
+				m := ispec.Manifest{}
+				mb, _ := json.Marshal(m)
+
+				Convey("Bad image manifest", func() {
+					_, err = il.PutImageManifest("test", d.String(), ispec.MediaTypeImageManifest, mb)
+					So(err, ShouldNotBeNil)
+
+					_, _, _, err = il.GetImageManifest("test", d.String())
+					So(err, ShouldNotBeNil)
+				})
+
+				Convey("Good image manifest", func() {
+					m := ispec.Manifest{Layers: []ispec.Descriptor{{Digest: d}}}
+					mb, _ = json.Marshal(m)
+					d := godigest.FromBytes(mb)
+					_, err = il.PutImageManifest("test", d.String(), ispec.MediaTypeImageManifest, mb)
+					So(err, ShouldBeNil)
+
+					_, _, _, err = il.GetImageManifest("test", d.String())
+					So(err, ShouldBeNil)
+
+					err = il.DeleteImageManifest("test", d.String())
+					So(err, ShouldBeNil)
+
+					_, _, _, err = il.GetImageManifest("test", d.String())
+					So(err, ShouldNotBeNil)
+				})
+
+				err = il.DeleteBlob("test", d.String())
+				So(err, ShouldBeNil)
+			})
+
+			err = il.DeleteBlobUpload("test", v)
 			So(err, ShouldBeNil)
 		})
 	})