feat(cache): dynamodb implementation (#953)

Signed-off-by: Catalin Hofnar <catalin.hofnar@gmail.com>

pkg/api/config/config.go

@@ -29,6 +29,7 @@ type StorageConfig struct {
 	GCDelay       time.Duration
 	GCInterval    time.Duration
 	StorageDriver map[string]interface{} `mapstructure:",omitempty"`
+	CacheDriver   map[string]interface{} `mapstructure:",omitempty"`
 }
 
 type TLSConfig struct {

pkg/api/controller.go

@@ -268,7 +268,7 @@ func (c *Controller) InitImageStore(reloadCtx context.Context) error {
 		var defaultStore storage.ImageStore
 		if c.Config.Storage.StorageDriver == nil {
 			// false positive lint - linter does not implement Lint method
-			//nolint:typecheck
+			//nolint:typecheck,contextcheck
 			defaultStore = local.NewImageStore(c.Config.Storage.RootDirectory,
 				c.Config.Storage.GC, c.Config.Storage.GCDelay,
 				c.Config.Storage.Dedupe, c.Config.Storage.Commit, c.Log, c.Metrics, linter,
@@ -296,7 +296,7 @@ func (c *Controller) InitImageStore(reloadCtx context.Context) error {
 			}
 
 			// false positive lint - linter does not implement Lint method
-			//nolint: typecheck
+			//nolint: typecheck,contextcheck
 			defaultStore = s3.NewImageStore(rootDir, c.Config.Storage.RootDirectory,
 				c.Config.Storage.GC, c.Config.Storage.GCDelay, c.Config.Storage.Dedupe,
 				c.Config.Storage.Commit, c.Log, c.Metrics, linter, store,
@@ -315,6 +315,7 @@ func (c *Controller) InitImageStore(reloadCtx context.Context) error {
 		if len(c.Config.Storage.SubPaths) > 0 {
 			subPaths := c.Config.Storage.SubPaths
 
+			//nolint: contextcheck
 			subImageStore, err := c.getSubStore(subPaths, linter)
 			if err != nil {
 				c.Log.Error().Err(err).Msg("controller: error getting sub image store")
@@ -443,7 +444,18 @@ func CreateCacheDatabaseDriver(storageConfig config.StorageConfig, log log.Logge
 
 			return driver
 		}
-		// used for tests, dynamodb when it comes
+		// dynamodb
+		if storageConfig.CacheDriver != nil {
+			dynamoParams := cache.DynamoDBDriverParameters{}
+			dynamoParams.Endpoint, _ = storageConfig.CacheDriver["endpoint"].(string)
+			dynamoParams.Region, _ = storageConfig.CacheDriver["region"].(string)
+			dynamoParams.TableName, _ = storageConfig.CacheDriver["tablename"].(string)
+
+			driver, _ := storage.Create("dynamodb", dynamoParams, log)
+
+			return driver
+		}
+
 		return nil
 	}
 

pkg/api/controller_test.go

@@ -99,6 +99,14 @@ func skipIt(t *testing.T) {
 	}
 }
 
+func skipDynamo(t *testing.T) {
+	t.Helper()
+
+	if os.Getenv("DYNAMODBMOCK_ENDPOINT") == "" {
+		t.Skip("Skipping testing without AWS DynamoDB mock server")
+	}
+}
+
 func TestNew(t *testing.T) {
 	Convey("Make a new controller", t, func() {
 		conf := config.New()
@@ -108,7 +116,7 @@ func TestNew(t *testing.T) {
 }
 
 func TestCreateCacheDatabaseDriver(t *testing.T) {
-	Convey("Test CreateCacheDatabaseDriver", t, func() {
+	Convey("Test CreateCacheDatabaseDriver boltdb", t, func() {
 		log := log.NewLogger("debug", "")
 
 		// fail create db, no perm
@@ -132,6 +140,35 @@ func TestCreateCacheDatabaseDriver(t *testing.T) {
 		driver = api.CreateCacheDatabaseDriver(conf.Storage.StorageConfig, log)
 		So(driver, ShouldBeNil)
 	})
+	skipDynamo(t)
+	skipIt(t)
+	Convey("Test CreateCacheDatabaseDriver dynamodb", t, func() {
+		log := log.NewLogger("debug", "")
+		dir := t.TempDir()
+		// good config
+		conf := config.New()
+		conf.Storage.RootDirectory = dir
+		conf.Storage.Dedupe = true
+		conf.Storage.RemoteCache = true
+		conf.Storage.StorageDriver = map[string]interface{}{
+			"name":          "s3",
+			"rootdirectory": "/zot",
+			"region":        "us-east-2",
+			"bucket":        "zot-storage",
+			"secure":        true,
+			"skipverify":    false,
+		}
+
+		conf.Storage.CacheDriver = map[string]interface{}{
+			"name":      "dynamodb",
+			"endpoint":  "http://localhost:4566",
+			"region":    "us-east-2",
+			"tableName": "BlobTable",
+		}
+
+		driver := api.CreateCacheDatabaseDriver(conf.Storage.StorageConfig, log)
+		So(driver, ShouldNotBeNil)
+	})
 }
 
 func TestRunAlreadyRunningServer(t *testing.T) {