fix(cov): coverage boltdb+dynamo (#2018)

Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>

pkg/test/image-utils/images.go

@@ -11,6 +11,7 @@ import (
 	"github.com/opencontainers/image-spec/specs-go"
 	ispec "github.com/opencontainers/image-spec/specs-go/v1"
 
+	"zotregistry.io/zot/pkg/common"
 	mTypes "zotregistry.io/zot/pkg/meta/types"
 	storageConstants "zotregistry.io/zot/pkg/storage/constants"
 )
@@ -145,7 +146,7 @@ func (img Image) AsImageMeta() mTypes.ImageMeta {
 		MediaType: img.Manifest.MediaType,
 		Digest:    img.ManifestDescriptor.Digest,
 		Size:      img.ManifestDescriptor.Size,
-		Manifests: []mTypes.ManifestData{
+		Manifests: []mTypes.ManifestMeta{
 			{
 				Size:     img.ManifestDescriptor.Size,
 				Digest:   img.ManifestDescriptor.Digest,
@@ -203,11 +204,14 @@ func CreateRandomVulnerableImageWith() ManifestBuilder {
 	return CreateImageWith().VulnerableLayers().RandomVulnConfig()
 }
 
-// CreateFakeTestSignature returns a test signature that is used to mark a image as signed
-// when creating a test Repo. It won't be recognized as a signature if uploaded to the repository directly.
-func CreateFakeTestSignature(subject *ispec.Descriptor) Image {
-	return CreateImageWith().RandomLayers(1, 10).DefaultConfig().
-		ArtifactType(TestFakeSignatureArtType).Subject(subject).Build()
+func CreateMockNotationSignature(subject *ispec.Descriptor) Image {
+	return CreateImageWith().RandomLayers(1, 10).EmptyConfig().Subject(subject).
+		ArtifactType(common.ArtifactTypeNotation).Build()
+}
+
+func CreateMockCosignSignature(subject *ispec.Descriptor) Image {
+	return CreateImageWith().RandomLayers(1, 10).EmptyConfig().Subject(subject).
+		ArtifactType(common.ArtifactTypeCosign).Build()
 }
 
 type BaseImageBuilder struct {

pkg/test/image-utils/images_test.go

@@ -8,6 +8,7 @@ import (
 	ispec "github.com/opencontainers/image-spec/specs-go/v1"
 	. "github.com/smartystreets/goconvey/convey"
 
+	"zotregistry.io/zot/pkg/common"
 	. "zotregistry.io/zot/pkg/test/image-utils"
 )
 
@@ -17,6 +18,15 @@ func TestImageBuilder(t *testing.T) {
 		t.FailNow()
 	}
 
+	Convey("Signature images", t, func() {
+		image := CreateDefaultImage()
+		cosign := CreateMockCosignSignature(image.DescriptorRef())
+		So(cosign.Manifest.ArtifactType, ShouldResemble, common.ArtifactTypeCosign)
+
+		notation := CreateMockNotationSignature(image.DescriptorRef())
+		So(notation.Manifest.ArtifactType, ShouldResemble, common.ArtifactTypeNotation)
+	})
+
 	Convey("Test Layer Builders", t, func() {
 		layerBuilder := CreateImageWith()
 

pkg/test/image-utils/multiarch.go

@@ -33,7 +33,7 @@ func (mi *MultiarchImage) DigestStr() string {
 func (mi MultiarchImage) AsImageMeta() mTypes.ImageMeta {
 	index := mi.Index
 
-	manifests := make([]mTypes.ManifestData, 0, len(index.Manifests))
+	manifests := make([]mTypes.ManifestMeta, 0, len(index.Manifests))
 
 	for _, image := range mi.Images {
 		manifests = append(manifests, image.AsImageMeta().Manifests...)