From 0ff940871b4ea189d66bcdf7fd60be2a04d564a2 Mon Sep 17 00:00:00 2001
From: Perma Alesheikh <me@prma.dev>
Date: Tue, 9 Jan 2024 12:47:19 +0330
Subject: [PATCH] use char when replacing a single character

Reasons:
- More idiomatic use of string.

Considering that they are constants, I don't anticipate any performance
gains related to heap-allocation.

Signed-off-by: Perma Alesheikh <me@prma.dev>
---
 src/email/message/arg/body.rs          | 2 +-
 src/email/message/arg/header.rs        | 2 +-
 src/email/message/arg/mod.rs           | 2 +-
 src/email/message/template/arg/body.rs | 2 +-
 src/email/message/template/arg/mod.rs  | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/email/message/arg/body.rs b/src/email/message/arg/body.rs
index e5eabd75..5ceeb19e 100644
--- a/src/email/message/arg/body.rs
+++ b/src/email/message/arg/body.rs
@@ -12,7 +12,7 @@ pub struct MessageRawBodyArg {
 
 impl MessageRawBodyArg {
     pub fn raw(self) -> String {
-        self.raw.join(" ").replace("\r", "").replace("\n", "\r\n")
+        self.raw.join(" ").replace('\r', "").replace('\n', "\r\n")
     }
 }
 
diff --git a/src/email/message/arg/header.rs b/src/email/message/arg/header.rs
index 29e43364..73713798 100644
--- a/src/email/message/arg/header.rs
+++ b/src/email/message/arg/header.rs
@@ -12,7 +12,7 @@ pub struct HeaderRawArgs {
 }
 
 pub fn raw_header_parser(raw_header: &str) -> Result<(String, String), String> {
-    if let Some((key, val)) = raw_header.split_once(":") {
+    if let Some((key, val)) = raw_header.split_once(':') {
         Ok((key.trim().to_owned(), val.trim().to_owned()))
     } else {
         Err(format!("cannot parse raw header {raw_header:?}"))
diff --git a/src/email/message/arg/mod.rs b/src/email/message/arg/mod.rs
index 216276bb..d78368d3 100644
--- a/src/email/message/arg/mod.rs
+++ b/src/email/message/arg/mod.rs
@@ -15,6 +15,6 @@ pub struct MessageRawArg {
 
 impl MessageRawArg {
     pub fn raw(self) -> String {
-        self.raw.join(" ").replace("\r", "").replace("\n", "\r\n")
+        self.raw.join(" ").replace('\r', "").replace('\n', "\r\n")
     }
 }
diff --git a/src/email/message/template/arg/body.rs b/src/email/message/template/arg/body.rs
index f577d196..47966587 100644
--- a/src/email/message/template/arg/body.rs
+++ b/src/email/message/template/arg/body.rs
@@ -12,7 +12,7 @@ pub struct TemplateRawBodyArg {
 
 impl TemplateRawBodyArg {
     pub fn raw(self) -> String {
-        self.raw.join(" ").replace("\r", "")
+        self.raw.join(" ").replace('\r', "")
     }
 }
 
diff --git a/src/email/message/template/arg/mod.rs b/src/email/message/template/arg/mod.rs
index 8798e089..eeb0224f 100644
--- a/src/email/message/template/arg/mod.rs
+++ b/src/email/message/template/arg/mod.rs
@@ -13,6 +13,6 @@ pub struct TemplateRawArg {
 
 impl TemplateRawArg {
     pub fn raw(self) -> String {
-        self.raw.join(" ").replace("\r", "")
+        self.raw.join(" ").replace('\r', "")
     }
 }